Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom legend to heatmap chart #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igorkasyanchuk
Copy link

Explanation About What Code Achieves:

Ability to specify the custom label on the heatmap.

Screenshots/GIFs:

http://prntscr.com/hvy8xu

Steps To Test:

Create a heatmap chart and pass

labels: ["Jan (8)", "Feb (2)", "Mar (5)", "Apr (1)", "May (8)", "Jun (8)", "Jul (7)", "Aug (0)", "Sep (7)", "Oct (1)", "Nov (2)", "December (9)"],
TODOs:
  • None

@pratu16x7 pratu16x7 force-pushed the master branch 2 times, most recently from 2db5155 to 423dc52 Compare April 21, 2018 13:52
@pratu16x7
Copy link
Contributor

screen shot 2018-04-22 at 4 12 17 pm

@igorkasyanchuk Thanks for contributing!
It seems that rather than passing hardcoded labels, the label numbers should rather be calculated from the total values in that month. Such a feature would then be togglable via chart options, with property (named maybe showDomainTotals ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants